Custom deltaBC, foundFV0 and bug fixes#350
Merged
Merged
Conversation
ekryshen
commented
Nov 26, 2021
ekryshen
commented
Collaborator
- custom deltaBC for collision-FT0 matching window, set to 300 bcs by default. Used as a workaround to increase FT0 matching efficiency for pilot beams
- foundFV0 index added in bcsel and evsel tables
- bux fixes in collision-FT0 matching algorithm
ekryshen
requested review from
a team,
alibuild,
iarsene,
jgrosseo and
ktf
as code owners
November 26, 2021 07:04
jgrosseo
reviewed
Nov 26, 2021
Comment on lines
+95
to
+96
| DECLARE_SOA_COLUMN(FoundFT0, foundFT0, int64_t); //! FT0 entry index in FT0s table (-1 if doesn't exist) | ||
| DECLARE_SOA_COLUMN(FoundFV0, foundFV0, int64_t); //! FV0 entry index in FV0A table (-1 if doesn't exist) |
Contributor
There was a problem hiding this comment.
Is this a index to the other table as it says?
It should then be int only.
And why not declare it as index column?
Collaborator
Author
There was a problem hiding this comment.
Indeed,I changed both foundFT0 and foundFV0 types to int32_t.
I am not sure whether is should be defined as index column. I will discuss with Anton. I suggest to merge it as it is now so that people could start using evsel with pilot data.
Contributor
|
Great, only one comment! |
jgrosseo
approved these changes
Nov 26, 2021
jgrosseo
enabled auto-merge (squash)
November 26, 2021 08:50
jezwilkinson
pushed a commit
to jezwilkinson/O2Physics
that referenced
this pull request
Dec 14, 2021
* Custom deltaBC, foundFV0 and bug fixes * foundFT0/FV0 index type changed to int32_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.